pgsql: Remove ancient PL/pgsql line numbering hack.

From: rhaas(at)postgresql(dot)org (Robert Haas)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove ancient PL/pgsql line numbering hack.
Date: 2010-08-02 03:46:54
Message-ID: 20100802034654.E0E367541D5@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove ancient PL/pgsql line numbering hack.

While this hack arguably has some benefit in terms of making PL/pgsql's
line numbering match the programmer's expectations, it also makes
PL/pgsql inconsistent with the remaining PLs, making it difficult for
clients to reliably determine where the error actually is. On balance,
it seems better to be consistent.

Pavel Stehule

Modified Files:
--------------
pgsql/src/pl/plpgsql/src:
pl_scanner.c (r1.5 -> r1.6)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_scanner.c?r1=1.5&r2=1.6)
pgsql/src/test/regress/expected:
domain.out (r1.45 -> r1.46)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/domain.out?r1=1.45&r2=1.46)
guc.out (r1.10 -> r1.11)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/guc.out?r1=1.10&r2=1.11)
plancache.out (r1.9 -> r1.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plancache.out?r1=1.9&r2=1.10)
plpgsql.out (r1.85 -> r1.86)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plpgsql.out?r1=1.85&r2=1.86)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-08-02 04:51:17 pgsql: Don't try to force use of -no-cpp-precomp on OS X.
Previous Message Tom Lane 2010-08-02 02:29:39 pgsql: Tweak a couple of macros in the regex code to suppress compiler