Re: gSoC - ADD MERGE COMMAND - code patch submission

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Boxuan Zhai <bxzhai2010(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "heikki(dot)linnakangas(at)enterprisedb(dot)com" <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Subject: Re: gSoC - ADD MERGE COMMAND - code patch submission
Date: 2010-07-10 17:39:02
Message-ID: 20100710173902.GD5477@fetter.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > Though, if the worst problem with this patch is the formatting, we're doing *quite* well.
>
> Well, the worst problem with it is that it hasn't touched the
> interesting part, ie, what happens at execution time. I haven't
> seen a design for that, which means it's impossible to evaluate
> whether the code that is here is of any use. We might need some
> other representation entirely.
>
> BTW, Fetter's version of the patch seems to be lacking any gram.y
> changes, but surely those exist already?

Oops.

Fixed that now in attached patch.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
merge3.diff text/plain 35.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2010-07-10 17:45:12 Re: gSoC - ADD MERGE COMMAND - code patch submission
Previous Message Tom Lane 2010-07-10 17:18:49 Re: gSoC - ADD MERGE COMMAND - code patch submission