Re: ECPG check variables hidden by locals v2

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ECPG check variables hidden by locals v2
Date: 2010-04-13 00:10:49
Message-ID: 201004130010.o3D0AnP28959@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


FYI, I think Michael Meskes applied this patch, though I didn't see you
emailed that it was applied.

---------------------------------------------------------------------------

Boszormenyi Zoltan wrote:
> Hi,
>
> here's a little beautified patch:
> - more logical parameter order in ECPGdump_a_type()
> - use mm_strdup() instead of strdup() (I notoriously forget this)
> - actually bail out with ET_FATAL if the local variable is
> of a different type than the global variable that was used in
> the DECLARE in the global scope
>
> Although with this patch we can only detect variables under
> DECLARE SECTIONs, so we can't detect the scenario
> in the attached test case. Should we? This test code would be
> a good candidate for the Underhanded C Contest. :-)
>
> Best regards,
> Zolt?n B?sz?rm?nyi
>
> --
> Bible has answers for everything. Proof:
> "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
> than these cometh of evil." (Matthew 5:37) - basics of digital technology.
> "May your kingdom come" - superficial description of plate tectonics
>
> ----------------------------------
> Zolt?n B?sz?rm?nyi
> Cybertec Sch?nig & Sch?nig GmbH
> http://www.postgresql.at/
>

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-04-13 00:21:16 Re: walreceiver is uninterruptible on win32
Previous Message Greg Smith 2010-04-12 22:46:46 Re: GSoC - proposal - Materialized Views in PostgreSQL