Re: pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()

From: David Fetter <david(at)fetter(dot)org>
To: Heikki Linnakangas <heikki(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()
Date: 2010-04-07 16:07:42
Message-ID: 20100407160742.GB854@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Apr 07, 2010 at 06:12:52AM +0000, Heikki Linnakangas wrote:
> Log Message:
> -----------
> Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset() during
> recovery. We might want to relax this in the future, but ThisTimeLineID
> isn't currently correct in backends during recovery, so the filename
> returned was wrong.

Is this Fujii Masao's patch? If so, please make sure to mention this
in your commit messages :)

Cheers,
David.
>
> Modified Files:
> --------------
> pgsql/doc/src/sgml:
> func.sgml (r1.512 -> r1.513)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml?r1=1.512&r2=1.513)
> pgsql/src/backend/access/transam:
> xlog.c (r1.389 -> r1.390)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c?r1=1.389&r2=1.390)
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers

--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-04-07 16:14:18 Re: pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()
Previous Message Simon Riggs 2010-04-07 11:00:44 Re: [COMMITTERS] pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-04-07 16:14:18 Re: pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()
Previous Message Tom Lane 2010-04-07 15:57:44 Re: Win32 timezone matching