pgsql: Don't pass an invalid file handle to dup2().

From: heikki(at)postgresql(dot)org (Heikki Linnakangas)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't pass an invalid file handle to dup2().
Date: 2010-04-01 20:12:22
Message-ID: 20100401201222.4E43F7541D0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Don't pass an invalid file handle to dup2(). That causes a crash on
Windows, thanks to a feature in CRT called Parameter Validation.

Backpatch to 8.2, which is the oldest version supported on Windows. In
8.2 and 8.3 also backpatch the earlier change to use DEVNULL instead of
NULL_DEV #define for a /dev/null-like device. NULL_DEV was hard-coded to
"/dev/null" regardless of platform, which didn't work on Windows, while
DEVNULL works on all platforms. Restarting syslogger didn't work on
Windows on versions 8.3 and below because of that.

Modified Files:
--------------
pgsql/src/backend/postmaster:
syslogger.c (r1.55 -> r1.56)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/syslogger.c?r1=1.55&r2=1.56)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-04-01 20:12:28 pgsql: Don't pass an invalid file handle to dup2().
Previous Message Simon Riggs 2010-04-01 17:08:33 Re: pgsql: Add contraint exclusion section to contraint docs.