Re: pq_setkeepalives* functions

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pq_setkeepalives* functions
Date: 2010-03-13 16:57:33
Message-ID: 201003131657.o2DGvX129517@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Tom Lane wrote:
> > >> This makes the function *not* like the other two, rather than
> > >> improving consistency.
> >
> > > Well, it makes it like some of the existing functions, but not like
> > > others. This applied patch fixes them all.
> >
> > This is making things worse, not better. You have just changed the
> > behavior, and not in a good way. Formerly these were no-ops on
> > a unix socket connection, and now they can throw errors.
>
> OK, reverted. Let me study the entire file.

Clarification, both changes reverted.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-03-13 16:58:40 Re: Dyamic updates of NEW with pl/pgsql
Previous Message Bruce Momjian 2010-03-13 16:56:57 Re: pq_setkeepalives* functions