Re: ecpg compiler warning about char* comparison

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: ecpg compiler warning about char* comparison
Date: 2010-03-08 12:15:10
Message-ID: 20100308121510.GA12566@feivel.credativ.lan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 08, 2010 at 10:46:03AM +0900, Takahiro Itagaki wrote:
> There is a complier warning in ecpg/ecpglib/error.c on HEAD:
> ...
> Instead, should we use "if (strcmp(...) == 0)" here?

Exactly. Thanks for spotting this, fixed in HEAD.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes(at)jabber(dot)org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-03-08 13:26:55 Re: testing cvs HEAD - HS/SR - xlog timeline 0 pg_xlogfile_name_offset
Previous Message Fujii Masao 2010-03-08 11:17:42 Re: Streaming replication and privilege