| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dominic Bevacqua <dominic(dot)bevacqua(at)bpmlogic(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint |
| Date: | 2010-03-08 00:47:42 |
| Message-ID: | 201003080047.o280lgo04791@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
BBruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > The attached patch checks for the proper return from BEGIN/COMMIT, and
> > > properly frees the libpq structures. In testing, this does return 3 as
> > > you expected.
> >
> > Really? It looks to me like you'd get exit(1). Maybe that's the right
> > thing, but MainLoop itself seems to return EXIT_USER not EXIT_FAILURE
> > when it gets an error.
>
> Sorry, you are right. I must have mis-read my tests. Updated patch
> attached.
I thought some more about it and realized I had to check for the
on-error-exit flag too. Updated patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
| Attachment | Content-Type | Size |
|---|---|---|
| /pgpatches/psql-1 | text/x-diff | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Savita | 2010-03-08 10:19:26 | BUG #5365: pg_ctl start gives error |
| Previous Message | Bruce Momjian | 2010-03-08 00:30:18 | Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takahiro Itagaki | 2010-03-08 01:46:03 | ecpg compiler warning about char* comparison |
| Previous Message | Joshua Waihi | 2010-03-08 00:34:21 | Re: [HACKERS] SQL compatibility reminder: MySQL vs PostgreSQL |