From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Mikko <mhannesy(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [GENERAL] trouble with to_char('L') |
Date: | 2010-02-28 04:28:12 |
Message-ID: | 201002280428.o1S4SCb29156@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Hiroshi Inoue wrote:
> Bruce Momjian wrote:
> > Hiroshi Inoue wrote:
> >> Bruce Momjian wrote:
> >>> Where are we on this issue?
> >> Oops I forgot it completely.
> >> I have a little improved version and would post it tonight.
> >
> > Ah, very good. Thanks.
>
> Attached is an improved version.
I spent many hours on this patch and am attaching an updated version.
I have restructured the code and added many comments, but this is the
main one:
* Ideally, the server encoding and locale settings would
* always match. Unfortunately, WIN32 does not support UTF-8
* values for setlocale(), even though PostgreSQL runs fine with
* a UTF-8 encoding on Windows:
*
* http://msdn.microsoft.com/en-us/library/x99tb11d.aspx
*
* Therefore, we must set LC_CTYPE to match LC_NUMERIC and
* LC_MONETARY, call localeconv(), and use mbstowcs() to
* convert the locale-aware string, e.g. Euro symbol, which
* is not in UTF-8 to the server encoding.
I need someone with WIN32 experience to review and test this patch.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Attachment | Content-Type | Size |
---|---|---|
/pgpatches/pg_locale | text/x-diff | 8.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2010-02-28 05:18:41 | Re: Hung postmaster (8.3.9) |
Previous Message | Ed L. | 2010-02-28 03:37:04 | Hung postmaster (8.3.9) |
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2010-02-28 05:28:17 | Re: Hot Standby query cancellation and Streaming Replication integration |
Previous Message | Tom Lane | 2010-02-28 04:22:00 | Re: Avoiding bad prepared-statement plans. |