Re: strict version of version_stamp.pl

From: David Fetter <david(at)fetter(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, jd(at)commandprompt(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: strict version of version_stamp.pl
Date: 2010-02-25 23:29:02
Message-ID: 20100225232902.GW2917@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 25, 2010 at 05:39:10PM -0500, Bruce Momjian wrote:
>
> David, I am sorry this didn't get applied, and the code has drifted too
> much to apply it now. Would you be able to make a new patch to make our
> Perl files strict?

Please find updated patch attached. It passes strict, warnings, and
perlcritic -4

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
version_stamp.diff text/plain 2.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Karl Schnaitter 2010-02-25 23:30:36 Re: A thought on Index Organized Tables
Previous Message Bruce Momjian 2010-02-25 23:21:58 Re: trouble with to_char('L')