pgsql: Provide some rather hokey ways for EXPLAIN to print FieldStore

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Provide some rather hokey ways for EXPLAIN to print FieldStore
Date: 2010-02-18 22:43:31
Message-ID: 20100218224331.A44C87541C5@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Provide some rather hokey ways for EXPLAIN to print FieldStore and assignment
ArrayRef expressions that are not in the immediate context of an INSERT or
UPDATE targetlist. Such cases never arise in stored rules, so ruleutils.c
hadn't tried to handle them. However, they do occur in the targetlists of
plans derived from such statements, and now that EXPLAIN VERBOSE tries to
print targetlists, we need some way to deal with the case.

I chose to represent an assignment ArrayRef as "array[subscripts] := source",
which is fairly reasonable and doesn't omit any information. However,
FieldStore is problematic because the planner will fold multiple assignments
to fields of the same composite column into one FieldStore, resulting in a
structure that is hard to understand at all, let alone display comprehensibly.
So in that case I punted and just made it print the source expression(s).

Backpatch to 8.4 --- the lack of functionality exists in older releases,
but doesn't seem to be important for lack of anything that would call it.

Modified Files:
--------------
pgsql/src/backend/utils/adt:
ruleutils.c (r1.323 -> r1.324)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c?r1=1.323&r2=1.324)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-02-18 22:43:39 pgsql: Provide some rather hokey ways for EXPLAIN to print FieldStore
Previous Message User Eulerto 2010-02-18 22:06:57 pgsimilarity - pg_similarity: Fixing PG_CONFIG path and including a