From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Add psql tab completion for DO blocks. |
Date: | 2010-02-15 09:27:12 |
Message-ID: | 20100215182702.9DD0.52131E4D@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> itagaki(at)postgresql(dot)org (Takahiro Itagaki) writes:
> This syntax synopsis is completely nuts:
> DO { [ LANGUAGE lang_name ] | code } ...
>
> I think that it would be logically correct without the square brackets,
Oops, that's correct.
> but as a matter of clarity I really doubt it's an improvement over the
> original.
We cannot write down the accurate syntax with BNF, right? We can have
0..1 "LANGUAGE lang_name", but must have just 1 "code" in any order.
How about the following description?
DO [ LANGUAGE lang_name ] code
because the psql tab completion adds LANGUAGE just after DO.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | marcin mank | 2010-02-15 09:36:40 | Re: [COMMITTERS] pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after |
Previous Message | Andres Freund | 2010-02-15 08:36:31 | Re: [COMMITTERS] pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after |
From | Date | Subject | |
---|---|---|---|
Next Message | Leonardo F | 2010-02-15 09:33:34 | Re: [FWD] About "Our CLUSTER implementation is pessimal" patch |
Previous Message | Heikki Linnakangas | 2010-02-15 09:16:58 | Re: [FWD] About "Our CLUSTER implementation is pessimal" patch |