From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: log_error_verbosity function display |
Date: | 2010-02-11 22:47:35 |
Message-ID: | 201002112247.o1BMlZ216064@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Jaime Casanova wrote:
> >> i like this with or without the (), but maybe we are breaking client
> >> apps if change that
>
> > Ah, so you like FUNCTION.
>
> You can NOT change the line tag without almost certainly breaking
> log-reading tools like pgfouine. Even changing the content of the line
> risks that, and for no visible gain.
>
> This seems like the worst form of bike-shedding to me. This log entry
> has been formatted this way since 7.4, and nobody has ever complained
> about it, until you suddenly decided it was a problem. Leave it be.
I propose to add '()' because it is confusing without it. I don't think
many people are using the feature or we would have received suggestions
for improvmement. As you can see, once I posted about it, there were a
number of people who wanted improvements.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Koichi Suzuki | 2010-02-11 22:49:03 | Re: [GENERAL] [HACKERS] Bug on pg_lesslog |
Previous Message | Koichi Suzuki | 2010-02-11 22:39:23 | Re: [GENERAL] [HACKERS] Bug on pg_lesslog |