Re: pgsql: Simplify validate_exec() by using access(2) to check file

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Simplify validate_exec() by using access(2) to check file
Date: 2010-01-14 04:38:36
Message-ID: 201001140438.o0E4cav10760@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Are there any outside code modifications now that this is thread-safe?
> > I can't find any myself.
>
> I only saw the note to not trust the function in threadable code.
> It might let us do some things later, but there doesn't seem to be
> an immediate application.

Thanks. That's what I thought too. We do have some code in libpq to
handle non-thread-safe functions (by taking a thread lock), but I didn't
see any cases where we did that when we called this code.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2010-01-14 11:08:02 pgsql: First part of refactoring of code for ResolveRecoveryConflict.
Previous Message Tom Lane 2010-01-14 04:36:42 Re: pgsql: Simplify validate_exec() by using access(2) to check file