From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)postgresql(dot)org> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Simplify validate_exec() by using access(2) to check file |
Date: | 2010-01-14 04:30:56 |
Message-ID: | 201001140430.o0E4UuN10021@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Tom Lane wrote:
> Log Message:
> -----------
> Simplify validate_exec() by using access(2) to check file permissions,
> rather than trying to implement the equivalent logic by hand. The motivation
> for the original coding appears to have been to check with the effective uid's
> permissions not the real uid's; but there is no longer any difference, because
> we don't run the postmaster setuid (indeed, main.c enforces that they're the
> same). Using access() means we will get it right in situations the original
> coding failed to handle, such as ACL-based permissions. Besides it's a lot
> shorter, cleaner, and more thread-safe. Per bug #5275 from James Bellinger.
Are there any outside code modifications now that this is thread-safe?
I can't find any myself.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-01-14 04:36:42 | Re: pgsql: Simplify validate_exec() by using access(2) to check file |
Previous Message | Tom Lane | 2010-01-14 00:14:06 | pgsql: Simplify validate_exec() by using access(2) to check file |