| From: | Michael Meskes <meskes(at)postgresql(dot)org> |
|---|---|
| To: | Hans-Jürgen Schönig <hs(at)cybertec(dot)at> |
| Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org> |
| Subject: | Re: patch to implement ECPG side tracing / tracking ... |
| Date: | 2010-01-13 13:38:07 |
| Message-ID: | 20100113133807.GA31808@feivel.credativ.lan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hans,
nce Jaime already asked for a use case, just a few small comments from
me.
> @@ -4,6 +4,7 @@
> #include "postgres_fe.h"
>
> #include <ctype.h>
> +#include <inttypes.h>
This is not portable. You don't want to include this header.
Did I see this right that you use the statement cache for auto-prepared
statements even if the statement is not auto prepared? Some statements are not
profiled, how did you decide which one to do?
There is no test case.
Before looking into it in detail I think we should first figure out if this
feature really has a benefit.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(at)jabber(dot)org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2010-01-13 13:38:44 | Re: ECPG patch causes warning |
| Previous Message | Hitoshi Harada | 2010-01-13 12:37:43 | Re: More frame options in window functions |