From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Make bit/varbit substring() treat any negative length as meaning |
Date: | 2010-01-07 19:53:27 |
Message-ID: | 20100107195327.9A0897541B9@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Make bit/varbit substring() treat any negative length as meaning "all the rest
of the string". The previous coding treated only -1 that way, and would
produce an invalid result value for other negative values.
We ought to fix it so that 2-parameter bit substring() is a different C
function and the 3-parameter form throws error for negative length, but
that takes a pg_proc change which is impractical in the back branches;
and in any case somebody might be relying on -1 working this way.
So just do this as a back-patchable fix.
Tags:
----
REL8_2_STABLE
Modified Files:
--------------
pgsql/src/backend/utils/adt:
varbit.c (r1.50.2.2 -> r1.50.2.3)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/varbit.c?r1=1.50.2.2&r2=1.50.2.3)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-01-07 19:53:32 | pgsql: Make bit/varbit substring() treat any negative length as meaning |
Previous Message | Tom Lane | 2010-01-07 19:53:22 | pgsql: Make bit/varbit substring() treat any negative length as meaning |