Re: [PATCH] EnableDisableTrigger Cleanup & Questions

"Jonah H. Harris" <jonah(dot)harris(at)gmail(dot)com> writes:
> On Thu, Nov 6, 2008 at 9:01 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It would have been useful to make this criticism before 8.3 was
>> released. I don't think it's reasonable to change it now.

> Well, I didn't have time to review code back in the 8.3 days, and ugly
> is ugly regardless of when it was originally committted. I'm not
> saying it needs to be an 8.4 fix, just that as a whole, several of the
> components of that patch (including rewrite) seem to be a little
> hackish and that they could be cleaned up in 8.5.

I have no objection to cleaning up the backend internals, but system
catalog definitions are client-visible. I don't think we should thrash
the catalog definitions for minor aesthetic improvements. Since 8.3 is
already out, that means client-side code (like pg_dump and psql, and
probably other programs we don't control) is going to have to deal with
the existing definition for the foreseeable future. Dealing with this
definition *and* a slightly cleaner one isn't a net improvement from the
client standpoint.

regards, tom lane