| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Chapman Flack <chap(at)anastigmatix(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] pgbench randomness initialization |
| Date: | 2018-03-02 19:50:46 |
| Message-ID: | 20094.1520020246@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> Hm ... so I tried to replicate this problem, and failed to: the log files
>> get made under the VPATH build directory, as desired, even without this
>> patch. Am I doing something wrong, or is this platform-dependent somehow?
> As I recall, it indeed works if the source directories are rw, but fails
> if they are ro because then the local mkdir fails. So you would have to do
> a vpath build with sources that are ro to get the issue the patch is
> fixing.
Ah, right you are. Apparently, if the source is rw, the temporary files
in question are made there but immediately deleted, so the bug isn't
obvious.
Fix verified and pushed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-02 19:54:42 | Re: 2018-03 Commitfest Summary (Andres #1) |
| Previous Message | Andres Freund | 2018-03-02 19:48:09 | Re: 2018-03 Commitfest Summary (Andres #1) |