| From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Verifying variable names in pgbench |
| Date: | 2009-12-28 03:38:59 |
| Message-ID: | 20091228123859.92F8.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
We can define variables with any names in pgbench,
but only can refer them with names that consist of [A-Za-z0-9_]+ .
It could cause confusion discussed here:
http://archives.postgresql.org/message-id/4B272833.8080500@2ndquadrant.com
The attached patch verifies variable names at definition.
$ pgbench -D var:name=value
(global): invalid variable name 'var:name'
It would help users to determine why their custom scripts failed
when they misuse "\setXXX :varname" (the colon should be removed).
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench_verify_varname_20091228.patch | application/octet-stream | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James William Pye | 2009-12-28 07:05:38 | Re: Additional SPI functions |
| Previous Message | Andres Freund | 2009-12-28 00:22:28 | Re: Small locking bugs in hs |