| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)postgresql(dot)org> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove code that attempted to rename index columns to keep them |
| Date: | 2009-12-23 16:52:46 |
| Message-ID: | 200912231652.nBNGqkt07644@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Log Message:
> -----------
> Remove code that attempted to rename index columns to keep them in sync with
> their underlying table columns. That code was not bright enough to cope with
> collision situations (ie, new name conflicts with some other column of the
> index). Since there is no functional reason to do this at all, trying to
> upgrade the logic to be bulletproof doesn't seem worth the trouble.
>
> This change means that both the index name and the column names of an index
> are set when it's created, and won't be automatically changed when the
> underlying table columns are renamed. Neatnik DBAs are still free to rename
> them manually, of course.
Does this mean this TODO items should be modified to remove the index
name mention?
Add ALTER TABLE RENAME CONSTRAINT, update index name also
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-12-23 17:10:37 | Re: [COMMITTERS] pgsql: Remove code that attempted to rename index columns to keep them |
| Previous Message | Tom Lane | 2009-12-23 16:43:44 | pgsql: Remove code that attempted to rename index columns to keep them |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-12-23 17:10:37 | Re: [COMMITTERS] pgsql: Remove code that attempted to rename index columns to keep them |
| Previous Message | Tom Lane | 2009-12-23 16:45:33 | Re: creating index names automatically? |