Re: Largeobject Access Controls (r2460)

Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> In both cases, I'm lost. Help?

They might be contrasted with the comments for myLargeObjectExists.
Since we use MVCC visibility in loread(), metadata for large object
also should be visible in MVCC rule.

If I understand them, they say:
* pg_largeobject_aclmask_snapshot requires a snapshot which will be
used in loread().
* Don't use LargeObjectExists if you need MVCC visibility.

> In acldefault(), there is this comment:
> /* Grant SELECT,UPDATE by default, for now */
> This doesn't seem to match what the code is doing, so I think we
> should remove it.

Ah, ACL_NO_RIGHTS is the default.

> I also notice that dumpBlobComments() is now misnamed, but it seems
> we've chosen to add a comment mentioning that fact rather than fixing it.

Hmmm, now it dumps not only comments but also ownership of large objects.
Should we rename it dumpBlobMetadata() or so?

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center