From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Crash on pg_ctl initdb without options |
Date: | 2009-12-14 08:25:58 |
Message-ID: | 20091214172558.8A97.52131E4D@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
pg_ctl initdb crashes if no options are passed.
Do we need additional if-null test for pgdata_opt just like post_opts?
$ pg_ctl initdb
sh: -c: line 0: syntax error near unexpected token `null'
sh: -c: line 0: `"/usr/local/pgsql/bin/initdb" (null)'
pg_ctl: database system initialization failed
Index: src/bin/pg_ctl/pg_ctl.c
===================================================================
--- src/bin/pg_ctl/pg_ctl.c (head)
+++ src/bin/pg_ctl/pg_ctl.c (fix)
@@ -656,6 +656,9 @@
if (exec_path == NULL)
exec_path = find_other_exec_or_die(argv0, "initdb", "initdb (PostgreSQL) " PG_VERSION "\n");
+ if (pgdata_opt == NULL)
+ pgdata_opt = "";
+
if (post_opts == NULL)
post_opts = "";
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2009-12-14 08:44:04 | Re: Winflex |
Previous Message | Peter Eisentraut | 2009-12-14 08:11:54 | Re: Hot Standby, release candidate? |