From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Robert Haas <robertmhaas(at)gmail(dot)com>, Scott Marlowe <scott(dot)marlowe(at)gmail(dot)com>, Thom Brown <thombrown(at)gmail(dot)com>, PGSQL Mailing List <pgsql-general(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> |
Subject: | Re: Installing PL/pgSQL by default |
Date: | 2009-12-12 03:35:17 |
Message-ID: | 200912120335.nBC3ZH703419@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I installed PL/pgSQL by default via initdb with the attached patch. The
> > only problem is that pg_dump still dumps out the language creation:
> > CREATE PROCEDURAL LANGUAGE plpgsql;
> > ALTER PROCEDURAL LANGUAGE plpgsql OWNER TO postgres;
> > What is odd is that I used the same process that initdb uses to create
> > other objects. Does anyone know why this is happening?
>
> I think pg_dump pays attention to what schema the objects are in,
> and that's most likely creating them in PUBLIC. Try adding
> "set search_path = pg_catalog".
>
> It's not impossible that we'll have to tweak pg_dump a bit; it's
> never had to deal with languages that shouldn't be dumped ...
I found that pg_dump tests for pg_language.lanispl == true, which is
true for all the stored procedure languages. I can easily special case
plpgsql, or check for FirstNormalObjectId, though I don't see that used
in pg_dump currently.
A more difficult issue is whether we should preserve the fact that
plpgsql was _removed_ in the pg_dump output, i.e, if someone removes
plpgsql from a database, do we issue a DROP LANGUAGE in pg_dump? I
don't remember us having to deal with anything like this before.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-12-12 04:57:03 | Re: Installing PL/pgSQL by default |
Previous Message | Peter Geoghegan | 2009-12-12 02:17:49 | Re: Postgres.exe Process taking too much memory and CPU usage - making the system extremely slow. |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2009-12-12 03:49:04 | Re: status update on Hot Standby and Streaming Replication |
Previous Message | Tom Lane | 2009-12-12 02:44:42 | Re: Need a mentor, and a project. |