From: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: bug: json format and auto_explain |
Date: | 2009-12-07 07:32:35 |
Message-ID: | 20091207163235.9546.52131E4D@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Looks like auto_explain is under the illusion that it need not call
> ExplainBeginOutput/ExplainEndOutput.
They were added by XML formatter; I suppose it worked on 8.4.
Explain{Begin/End}Output are static functions, so we cannot call them
from an external contrib module. Instead, I'll suggest to call them
automatically from ExplainPrintPlan. The original codes in ExplainPrintPlan
was moved into ExplainOneResult, that name might be debatable.
Patch attached.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
auto_explain_fix_20091207.patch | application/octet-stream | 2.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2009-12-07 07:36:14 | Re: named generic constraints [feature request] |
Previous Message | Itagaki Takahiro | 2009-12-07 06:54:16 | Re: YAML Was: CommitFest status/management |