Re: Re: [Pg-migrator-general] Composite types break pg_migrated tables

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Re: [Pg-migrator-general] Composite types break pg_migrated tables
Date: 2009-12-02 16:28:14
Message-ID: 200912021628.nB2GSEN25679@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Merlin Moncure wrote:
> On Thu, Aug 6, 2009 at 9:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > The half-formed idea I had was a set of GUC variables:
> >
> > set next_pg_class_oid = 12345;
> > set next_pg_type_oid = 12346;
> > set next_toast_table_oid = ...
> > set next_toast_index_oid = ...
> >
> > and finally it could do CREATE TABLE. ?CREATE TYPE would only need
> > next_pg_type_oid (except for a composite type).
>
> Is this idea still on the table for 8.5?

Well, pg_migrator still has these restrictions that will apply to
migrations to 8.5:

pg_migrator will not work if a user column is defined as:

o a user-defined composite data type
o a user-defined array data type
o a user-defined enum data type

You must drop any such columns and migrate them manually.

Having 'next_pg_type_oid' would fix that. The other three settings are
already handled by pg_migrator code. Having those three settings would
allow me to remove some pg_migrator code once we removed support for
migrations to 8.4.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2009-12-02 16:41:00 Re: Re: [Pg-migrator-general] Composite types break pg_migrated tables
Previous Message Tom Lane 2009-12-02 16:27:41 Re: Re: [Pg-migrator-general] Composite types break pg_migrated tables