Re: doc/src/sgml/Makefile versus VPATH

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: doc/src/sgml/Makefile versus VPATH
Date: 2009-10-06 16:41:21
Message-ID: 20091006164121.GK5929@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> So isn't this still pretty broken? I notice that the clean and
> distclean targets still use addprefix on a lot of temporary/intermediate
> files that I would think get made in the build directory, not the source
> directory.

Yeah, I noticed that too. I'm not too sure about it, because some of
those files we do want shipped in source tarballs; and they are
definitely cleaned in the builddir by maintainer-clean. I didn't want
to get into the detail of what's the ultimate distclean charter; my
immediate problem was that "make -C doc maintainer-clean" was not
getting rid of the stamp files and thus I was getting bit by the problem
that openjade was running all the time, even after I maintainer-cleaned.

By Peter's recent decree that tarballs are supposed to be built in
non-vpath-builds only, I am not really sure what should actually happen
here, both on build and on the various clean targets.

> The references to man files in srcdir in nonsql_manpage_files and
> adjacent macros seem a tad suspicious as well.

I agree, it probably merits more investigation.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-10-06 16:42:25 Re: [PATCH] Largeobject access controls
Previous Message KaiGai Kohei 2009-10-06 16:35:44 Re: [PATCH] Largeobject access controls