From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix a couple of issues in recent patch to print updates to |
Date: | 2009-10-03 18:04:57 |
Message-ID: | 20091003180457.96C76753FB7@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Fix a couple of issues in recent patch to print updates to postgresql.conf
settings: avoid calling superuser() in contexts where it's not defined,
don't leak the transient copies of GetConfigOption output, and avoid the
whole exercise in postmaster child processes.
I found that actually no current caller of GetConfigOption has any use for
its internal check of GUC_SUPERUSER_ONLY. But rather than just remove
that entirely, it seemed better to add a parameter indicating whether to
enforce the check.
Per report from Simon and subsequent testing.
Modified Files:
--------------
pgsql/src/backend/utils/misc:
guc-file.l (r1.61 -> r1.62)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc-file.l?r1=1.61&r2=1.62)
guc.c (r1.519 -> r1.520)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.519&r2=1.520)
pgsql/src/include/utils:
guc.h (r1.105 -> r1.106)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc.h?r1=1.105&r2=1.106)
pgsql/src/timezone:
pgtz.c (r1.63 -> r1.64)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/timezone/pgtz.c?r1=1.63&r2=1.64)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-10-03 20:04:39 | pgsql: Fix assorted memory leaks in pg_hba.conf parsing. |
Previous Message | User Andrewsn | 2009-10-03 12:51:41 | hstore-new - hstore-new: doc updates to reflect current state of code |