From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Rename StrNCpy to avoid conflictions on win32 |
Date: | 2009-09-18 13:34:38 |
Message-ID: | 200909181334.n8IDYcd19141@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> On Mon, 2009-09-07 at 11:36 +0200, Magnus Hagander wrote:
> > On Mon, Sep 7, 2009 at 04:40, Itagaki
> > Takahiro<itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> > > There might be some places to replace it to strlcpy() instead.
> >
> > Can't comment on that without looking at the code, but it wouldn't surprise me.
>
> There are some performance tradeoffs between these variants, and we
> already did change all (most?) of the not performance-critical calls to
> strlcpy a while ago.
Of all the macro names we use, I would have bet StrNCpy() was the last
one that would have conflicted with anything. :-O Did they copy it
from our code?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-09-18 13:36:08 | Re: happy birthday Tom Lane ... |
Previous Message | Merlin Moncure | 2009-09-18 13:06:30 | Re: happy birthday Tom Lane ... |