Re: More robust pg_hba.conf parsing/error logging

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Rafael Martinez <r(dot)m(dot)guerrero(at)usit(dot)uio(dot)no>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: More robust pg_hba.conf parsing/error logging
Date: 2009-09-09 14:18:17
Message-ID: 20090909141817.GC4132@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Rafael Martinez wrote:

> Problem:
> - --------
> If you define in pg_hba.conf a database or a user value with 'ALL'
> instead of 'all', you will lose access to *all* databases involved. The
> reload process will not report anything about 'ALL' been an invalid
> value and the new pg_hba.conf will be reloaded.
>
> This is the only thing in the log file:
> "LOG: received SIGHUP, reloading configuration files"

Aye, that's surprising. I think the correct fix here is to change the
strcmp comparisons to pg_strcasecmp() in several places in hba.c.

(BTW the business about appending newlines to special tokens in
next_token() seems ugly and underdocumented.)

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-09-09 14:20:07 Re: More robust pg_hba.conf parsing/error logging
Previous Message Pavel Stehule 2009-09-09 14:15:28 ToDo: array aggregates