| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Patch: update Bonjour support to the newer non-deprecated API |
| Date: | 2009-09-07 18:20:30 |
| Message-ID: | 20090907182030.GO8894@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > The source is here:
> > http://avahi.sourcearchive.com/documentation/0.6.25-1ubuntu1/avahi-compat-libdns__sd_2compat_8c-source.html
>
> After reading that code, I am content to remain forcibly non compatible
> with it. If we relied on this it would inject threading into the
> postmaster, which was precisely the thing that got the previous Avahi
> patch rejected last year :-(
Should we inject some sort of compile-time rejection of the
compatibility API? Like, say
#ifdef AVAHI_SERVICE_COOKIE
#error The Avahi implementation is incompatible
#endif
inside some #ifdef BONJOUR block?
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Creager | 2009-09-07 18:59:28 | Re: [Pgbuildfarm-members] Snow Leopard bison/flex build problem |
| Previous Message | Tom Lane | 2009-09-07 18:01:27 | Re: Patch: update Bonjour support to the newer non-deprecated API |