| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Greg Stark <gsstark(at)mit(dot)edu>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remove flatfiles.c |
| Date: | 2009-09-02 20:39:51 |
| Message-ID: | 20090902203950.GG5314@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Another weird consequence of this is that it bails out if it finds a
> > tuple larger than it can fit in one of the earlier pages; if there's
> > dead space to be compacted before that, it's not compacted.
>
> I don't find a lot wrong with that. The code defines its purpose as
> being to shorten the table file length. Once it hits a page that
> can't be emptied, it cannot shorten the file any further, so why
> shouldn't it stop?
All that work, and it wasn't capable of defragging the other pages? At
the very least it could register them in the FSM.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-09-02 20:42:59 | Re: remove flatfiles.c |
| Previous Message | Alvaro Herrera | 2009-09-02 20:38:15 | Re: clang's static checker report. |