Re: [COMMITTERS] pgsql: Move processing of startup-packet switches and GUC settings into

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Move processing of startup-packet switches and GUC settings into
Date: 2009-09-01 13:49:04
Message-ID: 20090901134903.GA7243@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Log Message:
> -----------
> Move processing of startup-packet switches and GUC settings into InitPostgres,
> to fix the problem that SetClientEncoding needs to be done before
> InitializeClientEncoding, as reported by Zdenek Kotala. We get at least
> the small consolation of being able to remove the bizarre API detail that
> had InitPostgres returning whether user is a superuser.

So, I think InitPostgres API could be deuglified a bit more by having
the launcher pass the database name instead of the OID. There's the
small race condition that the launcher could pass a database name and
have it be renamed before the worker starts, but I think it's small
enough to not matter much (note that it's already true that the launcher
could pass a database OID and have it be dropped before the worker
starts). Is anyone opposed to doing that change?

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-09-01 14:11:37 Re: [COMMITTERS] pgsql: Move processing of startup-packet switches and GUC settings into
Previous Message Tom Lane 2009-09-01 04:46:49 pgsql: Force VACUUM to recalculate oldestXmin even when we haven't

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-09-01 13:58:43 Re: remove flatfiles.c
Previous Message Magnus Hagander 2009-09-01 12:51:07 Copy out wording