Re: autovacuum launcher using InitPostgres

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: autovacuum launcher using InitPostgres
Date: 2009-08-31 15:38:16
Message-ID: 20090831153816.GF6060@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > To this end, InitPostgres has been split in two. The launcher only
> > calls the first half, the rest of the callers have been patched to
> > invoke the second half.
>
> This just seems truly messy :-(. Let me see if I can find something
> cleaner.

I was considering having InitPostgres be an umbrella function, so that
extant callers stay as today, but the various underlying pieces are
skipped depending on who's calling. For example I didn't like the bit
about starting a transaction or not depending on whether it was the
launcher.

> BTW, is it *really* the case that the AV launcher won't need
> RecentGlobalXmin? The way the HOT stuff works, I think anything that
> examines heap pages at all had better have that set.

Ugh. I forgot about that.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-08-31 15:47:53 Re: autovacuum launcher using InitPostgres
Previous Message Hans-Juergen Schoenig -- PostgreSQL 2009-08-31 15:34:18 Re: combined indexes with Gist - planner issues?