Re: hba load error and silent mode

From: Joshua Tolley <eggyknap(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: hba load error and silent mode
Date: 2009-08-24 14:21:38
Message-ID: 20090824142138.GZ31216@eddie
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 24, 2009 at 02:57:02PM +0200, Magnus Hagander wrote:
> On Mon, Aug 24, 2009 at 14:39, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
> >
> > Last night I had to deal with a puzzled user of version 8.4  who found
> > postgres refused to start but didn't log any error.  It turned out that
> > there was an error in the pg_hba.conf file, and the client was running in
> > silent mode (the SUSE default).
> >
> > This seems like a bug, and it's certainly not very postgres-like behaviour.
> >
> > Can we move the call to hba_load() in postmaster.c down a bit so it occurs
> > after the SysLogger is set up? ISTM we really need an absolute minimum of
> > code between the call to pmdaemonize() and SysLogger_Start().
>
> I can see other reasons that this would be good, so +1 from me unless
> there is any specific reason we can't start it earlier.

+1 from me, too, under the same condition. Since logging in really
interesting ways depends on a separate process, any logging before then will
be "abnormal", and any logs we create will probably show up in a relatively
unexpected place. The Principle of Least Surprise suggests we minimize that
possibility.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-08-24 14:31:12 Re: hba load error and silent mode
Previous Message Andrew Dunstan 2009-08-24 14:11:02 Re: hba load error and silent mode