pgsql: Fix old bug in log_autovacuum_min_duration code: it was relying

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix old bug in log_autovacuum_min_duration code: it was relying
Date: 2009-08-12 18:24:03
Message-ID: 20090812182403.1FA00753336@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix old bug in log_autovacuum_min_duration code: it was relying on being able
to access a Relation entry it had just closed. I happened to be testing with
CLOBBER_CACHE_ALWAYS, which made this a guaranteed core dump (at least on
machines where sprintf %s isn't forgiving of a NULL pointer). It's probably
quite unlikely that it would fail in the field, but a bug is a bug. Fix by
moving the relation_close call down past the logging action.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
pgsql/src/backend/commands:
analyze.c (r1.114.2.2 -> r1.114.2.3)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/analyze.c?r1=1.114.2.2&r2=1.114.2.3)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-08-12 20:53:31 pgsql: Allow backends to start up without use of the flat-file copy of
Previous Message Tom Lane 2009-08-12 18:23:56 pgsql: Fix old bug in log_autovacuum_min_duration code: it was relying