Re: Small annoyance in pgAdmin 1.10

Le vendredi 7 août 2009 à 18:12:00, Guillaume Lelarge a écrit :
> Le vendredi 7 août 2009 à 17:58:54, Magnus Hagander a écrit :
> > On Fri, Aug 7, 2009 at 17:09, Guillaume Lelarge<guillaume(at)lelarge(dot)info>
>
> wrote:
> > > Le vendredi 7 août 2009 à 09:56:34, Rainer Bauer a écrit :
> > >> Hello,
> > >>
> > >> this is no bug, but a little bit annoying: I sometimes accidently hit
> > >> the tab "Graphical Query Builder" in the Query window. No big deal, I
> > >> just click on "SQL Editor" to get back, but then a dialog pops up: "No
> > >> SQL query was generated.".
> > >>
> > >> Wouldn't it be possible to suppress that dialog?
> > >
> > > I looked a bit at this. We could at least avoid the dialog when no
> > > tables are put on the graphical query builder. I suppose it means we
> > > need to change the definition of gqbController::generateSQL() method.
> > > There's good chance it will be seen as a "new feature", rather than a
> > > debug.
> > >
> > > I'll record a ticket for this.
> >
> > While not a critical one, I'd qualify this as a bug. It seems like
> > quite useless behaviour :-)
>
> OK, I've changed the ticket.

Here is a patch that should fix this. Magnus, care to check it? I'm not ready
to commit it without proper review. It plays with pointers, and that scares me
a bit :)

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com