Re: Docbook toolchain interfering with patch review?

Robert Haas wrote:
> Yeah. I usually build the docs and read them if I'm making.... er
> proposing... an extensive change, but for simple stuff I just edit the
> SGML and figure that if it looks sane it probably is.
>
> I certainly don't test the doc portions of patches I review unless I
> see something sketchy in the markup.
>
> But I can't say I've ever had much trouble building the docs. I find
> it a bit odd that "make" in the doc directory does nothing; and "make"
> in doc/src does nothing, but "make" in doc/src/sgml does what you
> expect. I also find the slowness of openjade to be pretty annoying.
> But those are minor warts, not serious inconveniences that hinder
> reviewing.

FYI, bulding PDFs used to take _days_; we finally found and worked
around that openjade bug.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +