Re: pg_proc.probin should become text?

On Mon, Aug 03, 2009 at 10:03:11PM -0400, Tom Lane wrote:
> However, with the hex bytea output patch in place, it's *completely*
> broken. I offer the following pg_dump output:
>
> CREATE FUNCTION interpt_pp(path, path) RETURNS point
> LANGUAGE c
> AS '\\x2f686f6d652f706f7374677265732f706773716c2f7372632f746573742f726567726573732f726567726573732e736c', 'interpt_pp';
>
> which should of course have looked like this:
>
> CREATE FUNCTION interpt_pp(path, path) RETURNS point
> LANGUAGE c
> AS '/home/postgres/testversion/src/test/regress/regress.sl', 'interpt_pp';

Oh, of course! How could I have been so dense? ;)

> I think that the least painful solution might be to change
> pg_proc.probin to be declared as text. Otherwise we're going to need
> version-specific klugery in pg_dump and who knows where else.
>
> Comments?

+1 on changing it to text.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate