Re: BUG #4941: pg_stat_statements crash

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, alr(dot)nospamforme(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4941: pg_stat_statements crash
Date: 2009-07-27 03:30:42
Message-ID: 20090727033042.GG10327@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Itagaki Takahiro escribió:
>
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > > We should call [Read dumpfile] routine only once even on Windows.
> > Seems to me that you should simply do the load only when found is false.
>
> Here is a patch to fix pg_stat_statements on Windows.

Hmm, it seems the comment just above the patched line needs to be fixed.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2009-07-27 03:35:46 Re: BUG #4941: pg_stat_statements crash
Previous Message Itagaki Takahiro 2009-07-27 02:54:59 Re: BUG #4941: pg_stat_statements crash

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-07-27 03:35:46 Re: BUG #4941: pg_stat_statements crash
Previous Message Tom Lane 2009-07-27 03:21:34 Re: Merge Append Patch merged up to 85devel