Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros

From: Jeremy Kerr <jk(at)ozlabs(dot)org>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros
Date: 2009-07-20 00:52:23
Message-ID: 200907201052.23772.jk@ozlabs.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom,

> However, I think the whole patch is pretty useless. That code is not
> broken as it stands, and doesn't appear to really gain anything from
> the proposed change. Why should we risk any portability questions
> when the code isn't going to get either simpler or shorter?

This patch "clears the way" for the proceeding change (2/2). We use the
new inline functions to implement the proper checks to see if the
sigpipe-masking syscalls are needed.

We also need disable_sigpipe to be called when it's not the start of a
block, hence the separate type definition.

Cheers,

Jeremy

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2009-07-20 01:09:33 Re: SE-PostgreSQL?
Previous Message Andrew Dunstan 2009-07-20 00:49:20 Re: navigation menu for documents