| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] "could not reattach to shared memory" on Windows |
| Date: | 2009-07-14 14:02:37 |
| Message-ID: | 20090714140237.GD4799@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tsutomu Yamada wrote:
> This patch using VirtualAlloc()/VirtualFree() to avoid failing in
> reattach to shared memory.
>
> Can this be added to CommitFest ?
Since this fixes a very annoying bug present in older versions, I think
this should be backpatched all the way back to 8.2.
Some notes about the patch itself:
- please use ereport() instead of elog() for error messages
- Are you really putting the pgwin32_ReserveSharedMemory declaration
inside a function? Please move that into the appropriate header file.
- Failure to reserve memory in pgwin32_ReserveSharedMemory should be a
FATAL error I think, not simply LOG.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-07-14 14:14:24 | Re: Comments on automatic DML routing and explicit partitioning subcommands |
| Previous Message | Fujii Masao | 2009-07-14 14:01:27 | Synch Rep for CommitFest 2009-07 |