Re: TH to_char modifier doesn't work with HH12

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: TH to_char modifier doesn't work with HH12
Date: 2009-07-06 18:20:29
Message-ID: 200907061820.n66IKTe16920@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

David Fetter wrote:
> On Mon, Jul 06, 2009 at 01:53:28PM -0400, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> > > > Looking at the code, that looks like an oversight and the fix is
> > > > trivial:
> > >
> > > Yeah, I think you are right.
> > >
> > > > But given that it has been like that at least back to 8.0 which
> > > > is the oldest version I have installed right now: does anyone
> > > > see a reason not to fix that?
> > >
> > > +1 for backpatching as far as you conveniently can.
> >
> > Will we be _forever_ fixing coding mistakes in formatting.c?
>
> That depends on whether the project lasts forever ;)

I feel like someone should take a flame-thrower to that file. ;-)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Greg Stark 2009-07-06 18:26:24 Re: TH to_char modifier doesn't work with HH12
Previous Message David Fetter 2009-07-06 18:18:43 Re: TH to_char modifier doesn't work with HH12