| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Compiler warning |
| Date: | 2009-05-21 12:30:33 |
| Message-ID: | 200905211530.34744.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday 21 May 2009 14:29:51 Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > On Thursday 21 May 2009 10:01:59 Heikki Linnakangas wrote:
> >> Hmm, the patch looks fine to me. The strings are marked with
> >> gettext_noop() in the array, and passed through _() when used in errmsg.
> >
> > But his patch changes that to
> >
> > errhint("%s", _(wentry->drophint_msg))
> >
> > so it ends up being run through gettext twice.
>
> How so ? errhint only passes its first argument through gettext.
Yeah, not thinking clearly. So I guess this patch is OK if people care about
that warning.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2009-05-21 12:47:44 | psql is broken in 8.4 |
| Previous Message | Robert Haas | 2009-05-21 12:13:09 | Re: from_collapse_limit vs. geqo_threshold |