| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Compiler warning |
| Date: | 2009-05-21 10:08:55 |
| Message-ID: | 200905211308.56638.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday 21 May 2009 10:01:59 Heikki Linnakangas wrote:
> Peter Eisentraut wrote:
> > Note that applying this patch would introduce a double-translation issue
> > of the sort that you had complained about a while ago. I'm unsure which
> > way to proceed here.
>
> Hmm, the patch looks fine to me. The strings are marked with
> gettext_noop() in the array, and passed through _() when used in errmsg.
But his patch changes that to
errhint("%s", _(wentry->drophint_msg))
so it ends up being run through gettext twice. Which has recently been raised
as a concern. Both of these competing issues -- the compiler warning and
double translation -- appear to be minor in practice, but we apparently have
to make a choice which one we plan to fix now and in the future.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sam Mason | 2009-05-21 10:10:16 | Re: Fast ALTER TABLE ... ADD COLUMN ... DEFAULT xxx? |
| Previous Message | Peter Eisentraut | 2009-05-21 09:50:56 | Re: Fast ALTER TABLE ... ADD COLUMN ... DEFAULT xxx? |