Re: Some 8.4 changes needed according to pg_migrator testing

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Some 8.4 changes needed according to pg_migrator testing
Date: 2009-05-08 18:30:17
Message-ID: 20090508183017.GH10794@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas wrote:

> If we go with that, we should probably make the notion of a default
> collation explicit. We could set pg_database.datcollate/datctype column
> to NULL to mean "use the cluster default".

I'm not sure how this would work. If I initdb with a certain
locale/encoding and then create a database with default locale/encoding,
how would a restore work on a cluster that has been initdb'd with a
different locale/encoding? If you don't dump the locale specification,
it could very well not match what the user intended.

> I don't find the idea of creating mapping tables of locale names very
> appetizing. Looking at our encoding name mapping table, there's quite a
> few different spellings of different encoding names alone, let alone all
> locale names.

Yeah, it doesn't seem pleasant that way. When I proposed it I was
thinking that the mapping would be specified by the user. OTOH since
it's only pg_dumpall output that's the problem, this idea is not be very
useful because there will be no way for a tool to do the replacement.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-05-08 18:39:42 Re: Some 8.4 changes needed according to pg_migrator testing
Previous Message Tom Lane 2009-05-08 18:16:06 Re: Some 8.4 changes needed according to pg_migrator testing