pgsql: Change EXPLAIN output so that subplans and initplans

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Change EXPLAIN output so that subplans and initplans
Date: 2009-04-05 19:59:40
Message-ID: 20090405195940.65CF6754ADE@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Change EXPLAIN output so that subplans and initplans (particularly CTEs)
are individually labeled, rather than just grouped under an "InitPlan"
or "SubPlan" heading. This in turn makes it possible for decompilation of
a subplan reference to usefully identify which subplan it's referencing.
I also made InitPlans identify which parameter symbol(s) they compute,
so that references to those parameters elsewhere in the plan tree can
be connected to the initplan that will be executed. Per a gripe from
Robert Haas about EXPLAIN output of a WITH query being inadequate,
plus some longstanding pet peeves of my own.

Modified Files:
--------------
pgsql/src/backend/commands:
explain.c (r1.184 -> r1.185)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/explain.c?r1=1.184&r2=1.185)
pgsql/src/backend/nodes:
copyfuncs.c (r1.428 -> r1.429)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c?r1=1.428&r2=1.429)
equalfuncs.c (r1.351 -> r1.352)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c?r1=1.351&r2=1.352)
outfuncs.c (r1.357 -> r1.358)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c?r1=1.357&r2=1.358)
pgsql/src/backend/optimizer/plan:
subselect.c (r1.147 -> r1.148)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/subselect.c?r1=1.147&r2=1.148)
pgsql/src/backend/utils/adt:
ruleutils.c (r1.296 -> r1.297)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c?r1=1.296&r2=1.297)
pgsql/src/include/nodes:
primnodes.h (r1.147 -> r1.148)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/primnodes.h?r1=1.147&r2=1.148)

Browse pgsql-committers by date

  From Date Subject
Next Message User Gsmet 2009-04-05 20:17:30 pgfouine - pgfouine: applied [#1010529] Error in normalize for bigint
Previous Message Teodor Sigaev 2009-04-05 11:32:01 pgsql: Fix infinite loop while checking of partial match in pending