| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: question on bits32 wraparound check |
| Date: | 2009-04-04 00:47:59 |
| Message-ID: | 20090404004759.GR23023@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > So there's a minor issue on Takahiro-san fillfactor-on-toast patch,
> > which is that it does not hand out the last possible "kind" value. This
> > is a bits32 field, so at least theoretically on some platforms it will
> > be wider than 32 while on others it will be exactly 32.
>
> So just disallow kind > 31 (hard wired, with a note cross-referencing
> the datatype definition). Even if that leaves some unused bits on some
> particular platform, it's correct and ensures portable behavior.
So Takahiro-san got it right the first time. Thanks, committed that
way.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2009-04-04 01:08:05 | Re: Documentation Update: Document pg_start_backup checkpoint behavior |
| Previous Message | Tom Lane | 2009-04-03 23:41:50 | Re: psql \d commands and information_schema |