Re: pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.
Date: 2009-03-09 00:02:01
Message-ID: 20090309000201.GM3821@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> > pg_bind_textdomain_codeset must exist only on ENABLE_NLS.
>
> I think the previous coding, where it was defined but empty without
> ENABLE_NLS, was better. As-is, you've introduced an unnecessary reason
> for NLS-compiled loadable modules to fail to work with non-NLS core
> backends.

Uh-huh, interesting. Fixed (I hope).

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2009-03-09 13:08:06 pgsql: Add summarization comment about visibility functions.
Previous Message Alvaro Herrera 2009-03-09 00:01:32 pgsql: Revert pg_bind_textdomain_codeset to a existant-but-empty