| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: building pg_dump doesn't work |
| Date: | 2009-03-05 13:12:08 |
| Message-ID: | 20090305131208.GA4087@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> >> Seems doable.
>
> > Attached.
>
> The TWO_MEMBER_SCANKEYWORD business seems a bit dangerous --- if the
> header file is read without having #defined that correctly, bad things
> will happen. It might be better to leave that out, always define the
> struct the same, and just have pg_dump define PG_KEYWORD to fill the
> value field with zero. Given alignment considerations, you're not
> saving any space by omitting the field anyhow.
Fixed.
I also added #include type.h to the ecpg keywords.c file, which means we
don't need to redefine YYSTYPE at all on any of the three keywords.c
file. Looks cleaner overall.
Hopefully this is the last version of this patch.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| Attachment | Content-Type | Size |
|---|---|---|
| pgdump-parser-dep-4.patch | text/x-diff | 54.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-03-05 13:13:31 | Re: building pg_dump doesn't work |
| Previous Message | Magnus Hagander | 2009-03-05 12:57:30 | Re: Make SIGHUP less painful if pg_hba.conf is not readable |